Skip to content

remove repetitive code #121785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove repetitive code #121785

wants to merge 1 commit into from

Conversation

cuishuang
Copy link
Contributor

It seems that only one definition is needed here, but two definitions are accidentally included

@cuishuang
remove repetitive code
0d1280f 
Signed-off-by: cui fliter <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Feb 29, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 29, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=cuishuang
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_df20f6dc-c084-4a0e-86ed-d26dbed06a47
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=d1820c0b89b184b24bd136eec4ec2ff71313acd0
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_df20f6dc-c084-4a0e-86ed-d26dbed06a47
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_df20f6dc-c084-4a0e-86ed-d26dbed06a47
GITHUB_TRIGGERING_ACTOR=cuishuang
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/121785/merge
GITHUB_WORKFLOW_SHA=d1820c0b89b184b24bd136eec4ec2ff71313acd0
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
604 |                       where_clauses: (
    |  ____________________________________^
605 | |                         ast::TyAliasWhereClause::default(),
606 | |                     ),
    | |_____________________^ expected a tuple with 2 elements, found one with 1 element
    |
    = note: expected tuple `(TyAliasWhereClause, TyAliasWhereClause)`
               found tuple `(TyAliasWhereClause,)`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `rustc_builtin_macros` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:01:40

@ValShaped
Copy link

It looks like the two TyAliasWhereClauses are required. As noted in this comment, (rustc_ast/src/ast.rs#L3016,) they refer to different sides of the same type alias.

@bors
Copy link
Collaborator

bors commented Mar 1, 2024

☔ The latest upstream changes (presumably #121810) made this pull request unmergeable. Please resolve the merge conflicts.

@cuishuang
Copy link
Contributor Author

It looks like the two TyAliasWhereClauses are required. As noted in this comment, (rustc_ast/src/ast.rs#L3016,) they refer to different sides of the same type alias.

Thanks for the guidance, sorry to disturb you, I will close this PR

@cuishuang cuishuang closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cuishuang @rustbot @rust-log-analyzer @ValShaped @bors @TaKO8Ki